DaanHoogland commented on code in PR #6676:
URL: https://github.com/apache/cloudstack/pull/6676#discussion_r957001455
##########
plugins/deployment-planners/implicit-dedication/src/test/java/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java:
##########
@@ -382,8 +360,8 @@ private void initializeForTest(VirtualMachineProfileImpl
vmProfile, DataCenterDe
clustersWithEnoughCapacity.add(2L);
clustersWithEnoughCapacity.add(3L);
when(
- capacityDao.listClustersInZoneOrPodByHostCapacities(dataCenterId,
12L, noOfCpusInOffering * cpuSpeedInOffering, ramInOffering * 1024L * 1024L,
- Capacity.CAPACITY_TYPE_CPU,
true)).thenReturn(clustersWithEnoughCapacity);
+
capacityDao.listClustersInZoneOrPodByHostCapacities(dataCenterId, 12L,
noOfCpusInOffering * cpuSpeedInOffering, ramInOffering * 1024L * 1024L,
+ Capacity.CAPACITY_TYPE_CPU,
true)).thenReturn(clustersWithEnoughCapacity);
Review Comment:
can you omit these reformats from your PR?
##########
plugins/deployment-planners/implicit-dedication/src/test/java/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java:
##########
@@ -606,4 +584,4 @@ public boolean match(MetadataReader mdr,
MetadataReaderFactory arg1) throws IOEx
}
}
}
-}
+}
Review Comment:
can you omit these reformats from your PR?
##########
plugins/deployment-planners/implicit-dedication/src/test/java/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java:
##########
@@ -465,8 +443,8 @@ private void initializeForImplicitPlannerTest(boolean
preferred) {
@Configuration
@ComponentScan(basePackageClasses = {ImplicitDedicationPlanner.class},
- includeFilters = {@Filter(value =
TestConfiguration.Library.class, type = FilterType.CUSTOM)},
- useDefaultFilters = false)
+ includeFilters = {@Filter(value = TestConfiguration.Library.class,
type = FilterType.CUSTOM)},
+ useDefaultFilters = false)
Review Comment:
can you omit these reformats from your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
