DaanHoogland opened a new pull request, #6694: URL: https://github.com/apache/cloudstack/pull/6694
### Description This PR addresses parallel resource allocation as a generalization of the problem and solution described in #6644. Instead of the Global lock on the resources a reservation record is created which is added in the resource check count in the `ResourceLimitService`/`ResourceLimitManagerImpl`. As a convenience a `CheckedReservation` is created. This is an implementation of `AutoClosable` and can be used as a guard in a try-with-resource fashion. The close method of the `CheckedReservation` wil delete the reservation record. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> create a domain `limited` set domain limits in `limited` (for instance `user_vm == 2`) create an account `luser` create a network for `luser` create a first vm for this account in this network execute a similar script as: ``` for i in 1 2 3 4 5 do cmk deploy virtualmachine templateid=9d979443-2833-11ed-83ae-e884a5ebaa69 serviceofferingid=f2839454-a6db-43ee-8096-f5a52bf7d944 zoneid=f6e1fabb-9352-41ff-bbad-4d4b0b1aefae domainid=126a8ff7-31cf-4605-a90e-982c9a1cc5ea account=luser & done ``` to test on a multi MS platform some more elaborate script is needed (to be added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
