JoaoJandre commented on PR #6685: URL: https://github.com/apache/cloudstack/pull/6685#issuecomment-1235762568
> @JoaoJandre in itself the code looks good but I have a problem with the design; a join dao is supposed to get data from a view and not to manippulate or augment it. This is more in place in the service serving the API command. What made you decide to implement it like this? (in the `..JoinDaoImpl` classes) @DaanHoogland the response is already being built in the `DomainRouterJoinDaoImpl`, and there are already other similar procedures being made in the same method, such as retrieving the `podname` (lines 137 through 139). I understand that ideally this should be done elsewhere, but in that case this whole response builder method would have to be refactored, which would be out of scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
