samapraku opened a new issue, #6747:
URL: https://github.com/apache/cloudstack/issues/6747
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete
the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
API, UI
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main
branch.
-->
~~~
4.17.0.1
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network,
advanced networking, etc. N/A otherwise
-->
Advanced Network
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
Ubuntu 20.04
##### SUMMARY
<!-- Explain the problem/feature briefly -->
listNetworkOfferings api endpoint does not handle physical network tags
correctly.
When creating a new Shared Guest network and a Physical network is selected,
which has tags, the network offerings list in the dropdown is always empty
However, if the selected physical network does not have tags, the network
offerings are populated
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal
test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
Create a Physical network with and without tags
In Networks -> Guest Network -> Add Network -> Shared
If the physical network has tags, the network offering dropdown is always
empty.
Or make a listNetworkOfferings api request and pass a zoneid that has
physical network that has no tags.
Issue likely caused by this line:
https://github.com/apache/cloudstack/blob/bbc126057674a6cda047c2ea941d09af5c0e14a6/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java#L6600
<!-- Paste example playbooks or commands between quotes below -->
~~~
if (isTagged != null) {
if (isTagged) {
sc.addAnd("tags", SearchCriteria.Op.NNULL);
} else {
sc.addAnd("tags", SearchCriteria.Op.NULL);
}
}
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
When a physical network has tags, listNetworkOfferings should take the tags
into account
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
listNetworkOfferings always return empty when a physical network has tags
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
