shwstppr commented on PR #6759: URL: https://github.com/apache/cloudstack/pull/6759#issuecomment-1256105841
Did another test. LGTM ``` 2022-09-23 11:40:25,877 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Grabbing lock to check for database upgrade. 2022-09-23 11:40:25,898 DEBUG [c.c.u.d.VersionDaoImpl] (main:null) (logid:) Checking to see if the database is at a version before it was the version table is created 2022-09-23 11:40:25,920 DEBUG [c.c.u.SystemVmTemplateRegistration] (main:null) (logid:) Looking for file [ ./engine/schema/dist/systemvm-templates/metadata.ini ] in the classpath. 2022-09-23 11:40:25,920 DEBUG [c.c.u.SystemVmTemplateRegistration] (main:null) (logid:) Looking for file [ /usr/share/cloudstack-management/templates/systemvm/metadata.ini ] in the classpath. 2022-09-23 11:40:25,967 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) DB version = 4.17.0.1 Code Version = 4.17.1.0 2022-09-23 11:40:25,968 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Database upgrade must be performed from 4.17.0.1 to 4.17.1.0 2022-09-23 11:40:25,982 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41700to41710 to upgrade from 4.17.0.0-4.17.1.0 to 4.17.1.0 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Licensed to the Apache Software Foundation (ASF) under one 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- or more contributor license agreements. See the NOTICE file 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- distributed with this work for additional information 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- regarding copyright ownership. The ASF licenses this file 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- to you under the Apache License, Version 2.0 (the 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- "License"); you may not use this file except in compliance 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- with the License. You may obtain a copy of the License at 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- http://www.apache.org/licenses/LICENSE-2.0 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Unless required by applicable law or agreed to in writing, 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- software distributed under the License is distributed on an 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- KIND, either express or implied. See the License for the 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- specific language governing permissions and limitations 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- under the License. 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --; 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Schema upgrade from 4.17.0.0 to 4.17.1.0 2022-09-23 11:40:25,984 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --; 2022-09-23 11:40:25,985 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true' 2022-09-23 11:40:25,985 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true' 2022-09-23 11:40:25,985 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Retrieve the hypervisor_type from vm_instance 2022-09-23 11:40:25,985 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) DROP VIEW IF EXISTS `cloud`.`domain_router_view` 2022-09-23 11:40:26,001 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) CREATE VIEW `cloud`.`domain_router_view` AS select vm_instance.id id, vm_instance.name name, account.id account_id, account.uuid account_uuid, account.account_name account_name, account.type account_type, domain.id domain_id, domain.uuid domain_uuid, domain.name domain_name, domain.path domain_path, projects.id project_id, projects.uuid project_uuid, projects.name project_name, vm_instance.uuid uuid, vm_instance.created created, vm_instance.state state, vm_instance.removed removed, vm_instance.pod_id pod_id, vm_instance.instance_name instance_name, vm_instance.hypervisor_type, host_pod_ref.uuid pod_uuid, data_center.id data_center_id, data_center.uuid data_center_uuid, data_center.name data_center_name, data _center.networktype data_center_type, data_center.dns1 dns1, data_center.dns2 dns2, data_center.ip6_dns1 ip6_dns1, data_center.ip6_dns2 ip6_dns2, host.id host_id, host.uuid host_uuid, host.name host_name, host.cluster_id cluster_id, vm_template.id template_id, vm_template.uuid template_uuid, service_offering.id service_offering_id, service_offering.uuid service_offering_uuid, service_offering.name service_offering_name, nics.id nic_id, nics.uuid nic_uuid, nics.network_id network_id, nics.ip4_address ip_address, nics.ip6_address ip6_address, nics.ip6_gateway ip6_gateway, nics.ip6_cidr ip6_cidr, nics.default_nic is_default_nic, nics.gateway gateway, nics.netmask netmask, nics.mac_address mac_address, nics.broadcast_uri broadcast_uri, nics.isolation_uri isolation_uri, vpc.i d vpc_id, vpc.uuid vpc_uuid, vpc.name vpc_name, networks.uuid network_uuid, networks.name network_name, networks.network_domain network_domain, networks.traffic_type traffic_type, networks.guest_type guest_type, async_job.id job_id, async_job.uuid job_uuid, async_job.job_status job_status, async_job.account_id job_account_id, domain_router.template_version template_version, domain_router.scripts_version scripts_version, domain_router.is_redundant_router is_redundant_router, domain_router.redundant_state redundant_state, domain_router.stop_pending stop_pending, domain_router.role role, domain_router.software_version software_version from `cloud`.`domain_router` inner join `cloud`.`vm_instance` ON vm_instance.id = domain_router.id inner join `cloud`.`account` ON vm_instance.account_id = accou nt.id inner join `cloud`.`domain` ON vm_instance.domain_id = domain.id left join `cloud`.`host_pod_ref` ON vm_instance.pod_id = host_pod_ref.id left join `cloud`.`projects` ON projects.project_account_id = account.id left join `cloud`.`data_center` ON vm_instance.data_center_id = data_center.id left join `cloud`.`host` ON vm_instance.host_id = host.id left join `cloud`.`vm_template` ON vm_instance.vm_template_id = vm_template.id left join `cloud`.`service_offering` ON vm_instance.service_offering_id = service_offering.id left join `cloud`.`nics` ON vm_instance.id = nics.instance_id and nics.removed is null left join `cloud`.`networks` ON nics.network_id = networks.id left join `cloud`.`vpc` ON domain_router.vpc_id = vpc.id and vpc.removed is null left join `cloud`.`a sync_job` ON async_job.instance_id = vm_instance.id and async_job.instance_type = 'DomainRouter' and async_job.job_status = 0 2022-09-23 11:40:26,004 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- PR #6080 Change column `value` size from 255 to 4096 characters, matching the API "updateConfiguration" "value" size 2022-09-23 11:40:26,004 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) ALTER TABLE `cloud`.`account_details` MODIFY `value` VARCHAR(4096) NOT NULL 2022-09-23 11:40:26,054 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleanup upgrade Upgrade41700to41710 to upgrade from 4.17.0.0-4.17.1.0 to 4.17.1.0 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Licensed to the Apache Software Foundation (ASF) under one 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- or more contributor license agreements. See the NOTICE file 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- distributed with this work for additional information 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- regarding copyright ownership. The ASF licenses this file 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- to you under the Apache License, Version 2.0 (the 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- "License"); you may not use this file except in compliance 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- with the License. You may obtain a copy of the License at 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- http://www.apache.org/licenses/LICENSE-2.0 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2022-09-23 11:40:26,056 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Unless required by applicable law or agreed to in writing, 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- software distributed under the License is distributed on an 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- KIND, either express or implied. See the License for the 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- specific language governing permissions and limitations 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- under the License. 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --; 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Schema upgrade cleanup from 4.17.0.0 to 4.17.1.0 2022-09-23 11:40:26,057 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --; 2022-09-23 11:40:26,057 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleanup script Upgrade41700to41710 is executed successfully 2022-09-23 11:40:26,076 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Upgrade completed for version 4.17.1.0 ``` Merging based on the manual testing and LGTMs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
