DaanHoogland commented on code in PR #6797:
URL: https://github.com/apache/cloudstack/pull/6797#discussion_r991603961


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java:
##########
@@ -113,7 +113,8 @@ public KVMStoragePoolManager(StorageLayer storagelayer, 
KVMHAMonitor monitor) {
                     s_logger.warn(String.format("Duplicate StorageAdaptor type 
%s, not loading %s", info.storagePoolType().toString(), 
storageAdaptor.getName()));
                 } else {
                     try {
-                        
this._storageMapper.put(info.storagePoolType().toString(), 
storageAdaptor.newInstance());
+                        s_logger.info(String.format("adding storage adaptor 
for %s", storageAdaptor.getName()));
+                        
this._storageMapper.put(info.storagePoolType().toString(), 
storageAdaptor.getDeclaredConstructor().newInstance());

Review Comment:
   `getDeclaredConstructor().newInstance()` does the same as `newInstance()` 
but in a non-deprecated way. I haven´t figured it out yet, but I don´t think 
this will solve the issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to