DaanHoogland commented on code in PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#discussion_r992405345
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -286,6 +176,112 @@
import com.google.common.collect.Sets;
import com.googlecode.ipv6.IPv6Address;
import com.googlecode.ipv6.IPv6Network;
+import org.apache.cloudstack.acl.SecurityChecker;
Review Comment:
why the order of imports change? can you change that back please?
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -472,6 +469,8 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
public static final ConfigKey<Boolean>
ENABLE_DOMAIN_SETTINGS_FOR_CHILD_DOMAIN = new ConfigKey<Boolean>(Boolean.class,
"enable.domain.settings.for.child.domain", "Advanced", "false",
"Indicates whether the settings of parent domain should be applied
for child domain. If true, the child domain will get value from parent domain
if its not configured in child domain else global value is taken.",
true, ConfigKey.Scope.Global, null);
+ public static final ConfigKey<Integer> HOST_RESERVED_MEM_MB = new
ConfigKey<Integer>("Advanced", Integer.class, HOST_RESERVED_MEM_MB_STRING,
"1024",
Review Comment:
```suggestion
public static final ConfigKey<Integer> HOST_RESERVED_MEM_MB = new
ConfigKey<>("Advanced", Integer.class, HOST_RESERVED_MEM_MB_STRING, "1024",
```
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -120,7 +88,43 @@
import com.cloud.utils.nio.NioServer;
import com.cloud.utils.nio.Task;
import com.cloud.utils.time.InaccurateClock;
+import org.apache.cloudstack.agent.lb.IndirectAgentLB;
Review Comment:
can you undo the import re-order?
##########
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##########
@@ -203,6 +156,52 @@
import com.cloud.vm.dao.UserVmDetailsDao;
import com.cloud.vm.dao.VMInstanceDao;
import com.google.gson.Gson;
+import org.apache.cloudstack.annotation.AnnotationService;
Review Comment:
can you undo the import re-order please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
