JoaoJandre opened a new pull request, #6839:
URL: https://github.com/apache/cloudstack/pull/6839

   ### Description
   
   This PR fixes a NPE that occurs when trying to create a volume from a 
snapshot. This happens because when trying to log the `virtualMachineProfile` 
in the `AbstractStoragePoolAllocator#logStartOfSearch` method, its `toString()` 
method will throw a NPE since the `_vm` attribute is null.
   
   Some `toString()`s were also created in classes that had objects being 
logged during the volume creation process, as they were being logged as memory 
addresses since they had no `toString()` implementation.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   This was tested in a local lab, before this patch every time I tried to 
create a volume from a snapshot, a NPE was thrown. After the patch the volume 
creation from snapshot was fixed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to