weizhouapache commented on code in PR #6358:
URL: https://github.com/apache/cloudstack/pull/6358#discussion_r1004238267
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -54,6 +54,21 @@
*/
public static final Property<Boolean>
ENABLE_MANUALLY_SETTING_CPU_TOPOLOGY_ON_KVM_VM = new
Property<Boolean>("enable.manually.setting.cpu.topology.on.kvm.vm", true);
+ /**
+ * Disables memory ballooning on VM guests for overcommit.<br>
+ * By default overcommit feature enables balloon and sets currentMemory to
a minimum value.<br>
+ * Data type: Boolean.<br>
+ * Default value: <code>false</code>
+ */
+ public static final Property<Boolean> VM_MEMBALLOON_DISABLE = new
Property<>("vm.memballoon.disable", false);
+
+ /**
+ * The time interval (in seconds) at which the balloon driver will get
memory stats updates. This is equivalent to Libvirt's <code>--period</code>
parameter when using the dommemstat command.
+ * Data type: Integer.<br>
+ * Default value: <code>60</code>
+ */
+ public static final Property<Integer> VM_MEMBALLOON_STATS_PERIOD = new
Property<>("vm.memballoon.stats.period", 60);
Review Comment:
@joseflauzino
This will change the default behavior, should the default value be 0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
