Codegass opened a new pull request, #6883: URL: https://github.com/apache/cloudstack/pull/6883
### Description Fix: #6203 This PR introduces JUnit Assume API to the five test cases of `CABackgroundTaskTest`: [`testNullCert`](https://github.com/apache/cloudstack/blob/4c5a2ba3a6eb6399390c2f8963cb26e0e35fc058/server/src/test/java/org/apache/cloudstack/ca/CABackgroundTaskTest.java#L94-L99), [`testNullHost`](https://github.com/apache/cloudstack/blob/4c5a2ba3a6eb6399390c2f8963cb26e0e35fc058/server/src/test/java/org/apache/cloudstack/ca/CABackgroundTaskTest.java#L102-L108), [`testAutoRenewalEnabledWithExceptionsOnProvisioning`](https://github.com/apache/cloudstack/blob/main/server/src/test/java/org/apache/cloudstack/ca/CABackgroundTaskTest.java#L122), [`testAutoRenewalEnabledWithNoExceptionsOnProvisioning`](https://github.com/apache/cloudstack/blob/main/server/src/test/java/org/apache/cloudstack/ca/CABackgroundTaskTest.java#L111) , and [`testAutoRenewalDisabled`](https://github.com/apache/cloudstack/blob/main/server/src/test/java/org/apache/cloudstack/ca/CABackgroundTaskTest.java#L134). Take [`testAutoRenewalDisabled`](https://github.com/apache/cloudstack/blob/main/server/src/test/java/org/apache/cloudstack/ca/CABackgroundTaskTest.java#L134) as a example: Right now this case is asserting `certMap.size() == 1` before the actual testing target(`task.runInContext()`) is executed. ```java certMap.put(hostIp, expiredCertificate); Assert.assertTrue(certMap.size() == 1); ``` Since the test case `testAutoRenewalDisabled` contains 2 assertions, it may fail due to 2 reasons: * The functions related to the `certMap` have bugs.(Here is the `Assert.assertTrue(certMap.size() == 1)`) * The function `task.runInContext()` have bugs.(What we actually want to check with this test) Here I suggest replacing the `assertTrue` function with the `assumeThat` function, so when the precondition fails, JUnit can skip it instead of report a failurel. This can help us to focus on failure that is raised by the target testing function. **Before refactoring** ```java certMap.put(hostIp, expiredCertificate); Assert.assertTrue(certMap.size() == 1); ``` **After refactoring** ```java certMap.put(hostIp, expiredCertificate); Assume.assumeThat(icertMap.size() == 1, is(true)); ``` #### Brief changelog Replace `Assert.assertTrue(certMap.size() == 1);` with `Assume.assumeThat(icertMap.size() == 1, is(true));` for better code comprehension. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> The local cluster environment (KVM, UBUNTU 18.04) runs the test suite. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
