CharlesQueiroz opened a new pull request, #6899: URL: https://github.com/apache/cloudstack/pull/6899
### Description Currently the virtual router resources are not counted towards domain resource count. Only the CPU/MEM of user virtual machine are counted. If some customers have VR's with higher cpu/memory values than the default value of 1 core, 256MB RAM then they are consuming extra resources which are not counted towards the resource calculation of the domain/account. So two global settings are added to this change ``` "resource.count.running.routers" and "resource.count.running.routers.type" "resource.count.running.routers" can have either true of false "resource.count.running.routers.type" can have either "all" or "delta" The default value is "all" If "resource.count.running.routers" is true, then if "resource.count.running.routers.type" is "all", then all VR resources are counted towards the domain resource consumption For example: If VR is running with 4 cores, and 4GB ram, then all 4 cores and 4 GB are added to domain resource consumption If "resource.count.running.routers.type" is "delta" then the diff between the current VR CPU/ram and the default VR offering CPU/ram is considered for domain resource calculation. For example: If VR is running with 4 cores and 4Gb ram, then 3 cores and 4gb-0.25Gb will be counted for resource consumption If "resource.count.running.routers" is false, then even if VR has higher CPU/ram, then its not counted towards domain resource consumption Test cases: It can be tested using. nosetests --with-marvin --marvin-config=<your test config file>.cfg test_router_resources.py ``` ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup that may add test cases) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
