GutoVeronezi opened a new pull request, #6900: URL: https://github.com/apache/cloudstack/pull/6900
### Description Part of script `ssvm-check.sh` checks if the secondary storage is mounted on the SSVM. If it is not mounted, it tries to ping the "NFS server"; This process infers that the "NFS server" is the seventeenth element of file `/var/cache/cloud/cmdline`; however, the index of the elements can vary according to some configurations (vide `SecondaryStorageManagerImpl#finalizeVirtualMachineProfile`). For instance, in https://github.com/apache/cloudstack/pull/6348#issuecomment-1310020312 it is trying to ping the netmask. Futhermore, we do not have the information of the NSF server in the `/var/cache/cloud/cmdline` file. This PR intends to fix the check by adding the secondary storage server address to the file and retrieving it by the name. If the property is not in the file, it tries to validate the storage gateway to mitigate the "storage not mounted" situation. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### How Has This Been Tested? ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
