rohityadavcloud commented on code in PR #6907:
URL: https://github.com/apache/cloudstack/pull/6907#discussion_r1027664079
##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -1002,7 +1002,7 @@ def configure_l2tpIpsec(self, left, obj):
secret = CsFile(vpnsecretfilte)
secret.empty()
- secret.addeq("%s : PSK \"%s\"" % (left, psk))
+ secret.addeq(": PSK \"%s\"" % (psk))
Review Comment:
Update, from
https://github.com/apache/cloudstack/issues/4281#issue-684586236 it seems the
user's fix correlates with the syntax used.
##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -1002,7 +1002,7 @@ def configure_l2tpIpsec(self, left, obj):
secret = CsFile(vpnsecretfilte)
secret.empty()
- secret.addeq("%s : PSK \"%s\"" % (left, psk))
+ secret.addeq(": PSK \"%s\"" % (psk))
Review Comment:
@GutoVeronezi LGTM, but should we revert to old ? I don't know what the
syntax really means
```
secret.addeq("%s %%any : PSK \"%s\"" % (left, psk))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
