stephankruggg opened a new pull request, #6957:
URL: https://github.com/apache/cloudstack/pull/6957

   ### Description
   
   During the creation of a VPC offering, any type of service offering can be 
informed. However, selecting an improper service offering type can lead to a VR 
boot failure. Furthermore, during VPC or network offering creation, it is 
possible to provide an inactive service offering. 
   
   This PR allows the creation of VPC offerings only with VR service offerings, 
and blocks the creation of new VPC and network offerings with inactive service 
offerings. Any offering already created will maintain current behavior. 
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### How Has This Been Tested?
   
   I applied the changes in a local lab and attempted to create network 
offerings and VPC offerings with inactive service offerings. Additionally, I 
attempted to create VPC offerings with offerings in which the System VM type is 
not `domainrouter`. All attempts failed.
   
   Attempts where the System VM type is `domainrouter` and the offering is 
active were successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to