JoaoJandre commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1044421053
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java:
##########
@@ -172,8 +183,11 @@ public void execute() {
if (getDomainId() != null) {
cfgResponse.setScope("domain");
}
- if (getImageStoreId() != null){
- cfgResponse.setScope("imagestore");
+ if (getImageStoreId() != null) {
+ cfgResponse.setScope("imagestore");
+ }
+ if (getNetworkId() != null) {
+ cfgResponse.setScope("network");
Review Comment:
```suggestion
cfgResponse.setScope(ConfigKey.Scope.Network.name());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java:
##########
@@ -171,6 +182,9 @@ public void execute() {
if (getDomainId() != null) {
response.setScope("domain");
}
+ if (getNetworkId() != null) {
+ response.setScope("network");
Review Comment:
```suggestion
response.setScope(ConfigKey.Scope.Network.name());
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/ResetCfgCmd.java:
##########
@@ -157,6 +168,9 @@ public void execute() {
if (getImageStoreId() != null) {
response.setScope(ConfigKey.Scope.ImageStore.name());
}
+ if (getNetworkId() != null) {
+ response.setScope("network");
Review Comment:
```suggestion
response.setScope(ConfigKey.Scope.Network.name());
```
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java:
##########
@@ -34,7 +34,7 @@
public static final String CATEGORY_ALERT = "Alert";
public static enum Scope {
- Global, Zone, Cluster, StoragePool, Account, ManagementServer,
ImageStore, Domain
+ Global, Zone, Cluster, StoragePool, Account, Domain, ManagementServer,
ImageStore, Network
Review Comment:
Why change the `Domain` position on the enum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
