weizhouapache commented on code in PR #6574:
URL: https://github.com/apache/cloudstack/pull/6574#discussion_r1046839958
##########
setup/bindir/cloud-sysvmadm.in:
##########
@@ -23,7 +23,7 @@
#set -x
usage() {
- printf "\nThe tool stopping/starting running system vms and domain routers
\n\nUsage: %s: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-v]\n\n -d -
cloud DB server ip address, defaulted to localhost if not specified \n -u -
user name to access cloud DB, defaulted to "root" if not specified \n -p -
cloud DB user password, defaulted to no password if not specified \n\n -m - the
ip address of management server, defaulted to localhost if not specified\n\n -s
- stop then start all running SSVMs and Console Proxies \n -r - stop then start
all running Virtual Routers\n -a - stop then start all running SSVMs, Console
Proxies, and Virtual Routers \n -n - restart all Guest networks \n -t - number
of parallel threads used for stopping Domain Routers. Default is 10.\n -l - log
file location. Default is cloud.log under current directory.\n -z - do restart
only for the instances in the specific zone. If not specified, restart will
apply to instances in all zones\n -v - do restart all VPCs
in the entire system\n\n" $(basename $0) >&2
+ printf "\nThe tool stopping/starting running system vms and domain routers
\n\nUsage: %s: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-i] [-j] [-v]
[-i] [-j]\n\n -d - cloud DB server ip address, defaulted to localhost if not
specified \n -u - user name to access cloud DB, defaulted to "root" if not
specified \n -p - cloud DB user password, defaulted to no password if not
specified \n\n -m - the ip address of management server, defaulted to localhost
if not specified\n\n -s - stop then start all running SSVMs and Console Proxies
\n -r - stop then start all running Virtual Routers\n -a - stop then start all
running SSVMs, Console Proxies, and Virtual Routers \n -n - restart all Guest
networks \n -t - number of parallel threads used for stopping Domain Routers.
Default is 10.\n -l - log file location. Default is cloud.log under current
directory.\n -z - do restart only for the instances in the specific zone. If
not specified, restart will apply to instances in all zones\n -v -
do restart all VPCs in the entire system\n -i - do restart on instances with
specific IDs. Comma-separated instance IDs to be provided. Works ony when
restarting SSVMs, CPVMs or VRs\n -j - do restart on instances from the
specified database table. If not specified, restart will apply on instances
present in cloud.vm_instance database table. Works ony when restarting SSVMs,
CPVMs or VRs\n\n" $(basename $0) >&2
Review Comment:
@shwstppr
can you organize this by multiple lines ? it is hard to review.
##########
setup/bindir/cloud-sysvmadm.in:
##########
@@ -23,7 +23,7 @@
#set -x
usage() {
- printf "\nThe tool stopping/starting running system vms and domain routers
\n\nUsage: %s: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-v]\n\n -d -
cloud DB server ip address, defaulted to localhost if not specified \n -u -
user name to access cloud DB, defaulted to "root" if not specified \n -p -
cloud DB user password, defaulted to no password if not specified \n\n -m - the
ip address of management server, defaulted to localhost if not specified\n\n -s
- stop then start all running SSVMs and Console Proxies \n -r - stop then start
all running Virtual Routers\n -a - stop then start all running SSVMs, Console
Proxies, and Virtual Routers \n -n - restart all Guest networks \n -t - number
of parallel threads used for stopping Domain Routers. Default is 10.\n -l - log
file location. Default is cloud.log under current directory.\n -z - do restart
only for the instances in the specific zone. If not specified, restart will
apply to instances in all zones\n -v - do restart all VPCs
in the entire system\n\n" $(basename $0) >&2
+ printf "\nThe tool stopping/starting running system vms and domain routers
\n\nUsage: %s: [-d] [-u] [-p] [-m] [-s] [-r] [-a] [-t] [-n] [-z] [-i] [-j] [-v]
[-i] [-j]\n\n -d - cloud DB server ip address, defaulted to localhost if not
specified \n -u - user name to access cloud DB, defaulted to "root" if not
specified \n -p - cloud DB user password, defaulted to no password if not
specified \n\n -m - the ip address of management server, defaulted to localhost
if not specified\n\n -s - stop then start all running SSVMs and Console Proxies
\n -r - stop then start all running Virtual Routers\n -a - stop then start all
running SSVMs, Console Proxies, and Virtual Routers \n -n - restart all Guest
networks \n -t - number of parallel threads used for stopping Domain Routers.
Default is 10.\n -l - log file location. Default is cloud.log under current
directory.\n -z - do restart only for the instances in the specific zone. If
not specified, restart will apply to instances in all zones\n -v -
do restart all VPCs in the entire system\n -i - do restart on instances with
specific IDs. Comma-separated instance IDs to be provided. Works ony when
restarting SSVMs, CPVMs or VRs\n -j - do restart on instances from the
specified database table. If not specified, restart will apply on instances
present in cloud.vm_instance database table. Works ony when restarting SSVMs,
CPVMs or VRs\n\n" $(basename $0) >&2
Review Comment:
duplicated `[-i] [-j]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
