JoaoJandre opened a new pull request, #7052:
URL: https://github.com/apache/cloudstack/pull/7052
### Description
ACS only allows root admins to enter tags during the creation of service,
disk, and network offerings; however, in private cloud environments, domain
admin accounts may have autonomy and knowledge of the infrastructure, being
able to direct resources according to their needs.
To enable this behavior, a new account-level setting
(`allow.domain.admins.to.create.offerings.with.tags`) has been created. When
disabled (default), the previous behavior is maintained; when enabled, the
domain admin account can enter tags when creating disk and service offerings.
As we did not see a use case for network offering tags, these were not touched,
that is, this new configuration will not affect network offering creation.
In addition, the UI has been changed to allow domain admins to inform these
fields when the configuration is enabled. To enable this UI behavior, a new API
was created, `isAccountAllowedToCreateOfferingsWithTags`, which only receives
the ID of the account to be validated, and returns true if the account can
create offerings with tags and false otherwise.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
With the `allow.domain.admins.to.create.offerings.with.tags` set to false
(default), and using CloudMonkey logged in as a domain admin, I tried to call
the create/update service/disk offering APIs while passing some tags as
parameters, all the calls returned exceptions.
I Then set the configuration to `true`, and recalled the APIs with the same
parameters, and all of them successfully ran.
In the UI, logged in as a domain admin, and the
`allow.domain.admins.to.create.offerings.with.tags` set to false, I opened the
create disk/compute offering forms, and the tags fields did not appear.
I then set the configuration to `true`, and retried opening the create
disk/compute offering forms, the tags did appear, and I successfully created
the offerings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
