weizhouapache commented on PR #7063:
URL: https://github.com/apache/cloudstack/pull/7063#issuecomment-1375625207

   > Hi @weizhouapache, can you extract the inactive check to a method and 
reuse it in both scenarios to avoid code duplication?
   
   @stephankruggg 
   suggested changes are committed.
   
   for this, I think it is not necessary to create a public method (used by 2 
classes) which has only 1 condition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to