weizhouapache commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1071031134
########## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ########## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add support for VMware 8.0 +INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '8.0', 1024, 0, 59, 64, 1, 1); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '8.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='7.0.3.0'; + Review Comment: @rohityadavcloud the upgrade of SDK to 8.0 looks good. Anyone has tested the hypervisor and guest os mappings of vmware 8 ? It not, it might be better to add it in a separated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org