GutoVeronezi commented on code in PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072786938
##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -303,6 +310,16 @@ private ConsoleEndpoint
composeConsoleAccessEndpoint(String rootUrl, VirtualMach
return consoleEndpoint;
}
+ protected void persistConsoleSession(String sessionUuid, long instanceId,
long hostId) {
+ ConsoleSessionVO consoleSessionVo = new ConsoleSessionVO();
+ consoleSessionVo.setUuid(sessionUuid);
Review Comment:
On principle, I would rather not create a constructor for informing the
object properties, as the more properties it has, the longer the constructor
would get, becoming harder to read/interpret the code. For Python, that
supports keyword arguments, this approach works fine, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
