stephankruggg commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1083031782
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 60000; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 60000;
- protected long _heartBeatUpdateFreq = 60000;
+ protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
The intention of this PR is to allow the increase (or the decrease) of the
frequency of the KVM HA heartbeat checks, which is currently not possible. For
example, if one wants to guarantee that a critical host is down for the least
amount of time possible, one can increase the frequency of the heartbeat with
the changes proposed.
Even though not necessarily related to the same use case, the
externalization of other properties would achieve the same general goal of
increasing the flexibility of the system. Since everyone benefits from this,
and they are all related to the same topic (KVM HA), I am open to work on the
externalization of them in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
