weizhouapache commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1084316571
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1462,12 +1480,12 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
}
}
- if (ntwkOff.getGuestType() != GuestType.Shared &&
(!StringUtils.isAllBlank(routerIp, routerIpv6))) {
- throw new InvalidParameterValueException("Router IP can be
specified only for Shared networks");
+ if (ntwkOff.getGuestType() == GuestType.L2 &&
(!StringUtils.isAllBlank(cmd.getRouterIPv4(), cmd.getRouterIPv6()))) {
Review Comment:
@DaanHoogland
I was just wondering if there are checks to verify the source nat is
supported by the network (or offering) and the specified IP is available. I did
not find the checks.
I will have a look again. If you know the position of checks, it would be
great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
