soreana commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1401576077
> > @wido That in my view > > > Overall it is looking good. > > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or example. Do we maybe need to set some lower and upper limits? > > > > > > @wido That is a good idea, but I'm not sure if there is a good way to validate the settings. Do you have any suggestion, where I can run those validations? > > @soreana can you add a setting for that? 😋 > > @wido @weizhouapache is this really needed? this is an operator action anyway, isn´t it? they should know how to tune their cloud....!?! @DaanHoogland I have mixed feelings about new global settings. On one hand, I like to prevent any damage. On the other hand, I love to let admins who don't know how to tune their data center screw it. 😈 Anyway, It would be better to merge this on 4.18 and work on the new global setting in a different milestone. I've created the #7129 to track that. Please assign it to me and plan it for the 4.18.1 milestone. @DaanHoogland @wido, @weizhouapache, @vladimirpetrov Thanks for testing and commenting. I'm working on a fix to see what went wrong with the database value and the test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
