Pavan-Nambi commented on code in PR #7134:
URL: https://github.com/apache/cloudstack/pull/7134#discussion_r1088946912
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -810,7 +810,7 @@ public class ManagementServerImpl extends ManagerBase
implements ManagementServe
protected StateMachine2<State, VirtualMachine.Event, VirtualMachine>
_stateMachine;
static final ConfigKey<Integer> vmPasswordLength = new
ConfigKey<Integer>("Advanced", Integer.class, "vm.password.length", "6",
"Specifies the length of a randomly generated password", false);
- static final ConfigKey<String> vmPasswordComplexity = new
ConfigKey<String>("Advanced", String.class, "vm.password.complexity",
"^(?=.{6,})(?=.*[A-Z])(?=.*[a-z])(?=.*[@#%&^~.,!,?,:,;])", "Specifies the
pattern for generated password", false);
+ static final ConfigKey<String> vmPasswordComplexity = new
ConfigKey<String>("Advanced", String.class, "vm.password.complexity", ".*",
"Specifies the pattern for generated password", true);
Review Comment:
sorry if i am wrong but if you are referring to passwordgenerator.java file
i have added code to add special characters too
and the reasoni used .* is
in above conversation this was told so
@Pavan-Nambi, to keep compatibility with the current behavior (accept any
password generated), the default value should be .*; then, one should change
the configuration via API/UI according to the necessity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
