shwstppr commented on code in PR #7059:
URL: https://github.com/apache/cloudstack/pull/7059#discussion_r1094196789


##########
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##########
@@ -19,6 +19,19 @@
 -- Schema upgrade from 4.17.2.0 to 4.18.0.0
 --;
 
+-- Add el9 guest OS mappings
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9', 'KVM', 'default', 
'AlmaLinux 9');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'CentOS 9', 'KVM', 'default', 
'CentOS 9');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Oracle Linux 9', 'KVM', 
'default', 'Oracle Linux 9');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Red Hat Enterprise Linux 9', 
'KVM', 'default', 'Red Hat Enterprise Linux 9');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Rocky Linux 9', 'KVM', 
'default', 'Rocky Linux 9');
+
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9', 'VMware', 
'7.0.3.0', 'otherLinux64Guest');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'CentOS 9', 'VMware', '7.0.3.0', 
'centos9_64Guest');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Oracle Linux 9', 'VMware', 
'7.0.3.0', 'otherLinux64Guest');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Red Hat Enterprise Linux 9', 
'VMware', '7.0.3.0', 'rhel9_64Guest,');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Rocky Linux 9', 'VMware', 
'7.0.3.0', 'otherLinux64Guest');

Review Comment:
   ```suggestion
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9', 'VMware', '7.0', 
'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Oracle Linux 9', 'VMware', 
'7.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Red Hat Enterprise Linux 9', 
'VMware', '7.0', 'rhel9_64Guest,');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Rocky Linux 9', 'VMware', 
'7.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9', 'VMware', 
'7.0.1.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Oracle Linux 9', 'VMware', 
'7.0.1.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Red Hat Enterprise Linux 9', 
'VMware', '7.0.1.0', 'rhel9_64Guest,');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Rocky Linux 9', 'VMware', 
'7.0.1.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9', 'VMware', 
'7.0.2.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Oracle Linux 9', 'VMware', 
'7.0.2.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Red Hat Enterprise Linux 9', 
'VMware', '7.0.2.0', 'rhel9_64Guest,');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Rocky Linux 9', 'VMware', 
'7.0.2.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 9', 'VMware', 
'7.0.3.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Oracle Linux 9', 'VMware', 
'7.0.3.0', 'otherLinux64Guest');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Red Hat Enterprise Linux 9', 
'VMware', '7.0.3.0', 'rhel9_64Guest,');
   CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Rocky Linux 9', 'VMware', 
'7.0.3.0', 'otherLinux64Guest');
   ```
   @weizhouapache would this make sense?
   I've removed CentOS9 as that doesn't show up in the compatibility matrix, 
https://www.vmware.com/resources/compatibility/search.php?deviceCategory=software&details=1&partner=272&releases=448&page=1&display_interval=10&sortColumn=Partner&sortOrder=Asc&testConfig=16
   cc @rohityadavcloud @DaanHoogland 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to