GutoVeronezi commented on PR #7140: URL: https://github.com/apache/cloudstack/pull/7140#issuecomment-1423269734
> I am hesistent to merge this before 4.18 as it introduces no functionality or fixes any reported use case from failing. @rohityadavcloud @weizhouapache @GutoVeronezi , can you give your opinions on how serious the fixes in here are? @DaanHoogland, as it is just a refactoring (to fix the bugs and vulnerabilities reported by the SonarCloud), I see no problem in adding this one to 4.18. We just have to guarantee that nothing broke with the refactoring; by the results of the tests and the code analysis, the changes seems OK; manual tests are welcome, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
