weizhouapache commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r1106353894
##########
core/src/main/java/com/cloud/agent/api/storage/MigrateVolumeCommand.java:
##########
@@ -36,6 +36,7 @@ public class MigrateVolumeCommand extends Command {
String attachedVmName;
Volume.Type volumeType;
String hostGuidInTargetCluster;
+ Long newIops;
Review Comment:
Can you explain why newIops is added , not newIopsRead/newIopsWrite ?
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -5055,6 +5069,29 @@ private Answer execute(MigrateVolumeCommand cmd) {
volumePath = vmMo.getVmdkFileBaseName(disk);
}
}
+ if (cmd.getNewIops() != null) {
+ String vmwareDocumentation =
"https://kb.vmware.com/s/article/68164";;
Review Comment:
What if new disk offering does not have IOPS limitation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
