DaanHoogland commented on PR #6282: URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1430945183
> > @DaanHoogland sorry for the delay in answer, about the discussion of the usage of override of methods `equals` and `hashCode` in NicVO, I stand by my belief that this is the best approach and, in particular, I can't think of any scenario in which this change could cause any regression. Please do not take what I say offensively, but if any of the participants can describe a concrete case of such a regression, rather than just speculation, I would be immensely grateful. cc @harikrishna-patnala @weizhouapache. > > In addition, I will change this PR to draft, until this point of disagreement is resolved, thus avoiding an early merge. > > @SadiJr I agree with you, if the object does not have a unique key (id). > > Anyway, this change should be ok. cc @DaanHoogland @harikrishna-patnala Sorry @SadiJr , I am not offended and I don ´t even recall the discussion. Though the subject you describe is a known cause for bugs, I don´t recall seeing this happening in cloudstack yet. Also I lgtm´d this PR, but please ask me for a re-review, when you are done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
