DaanHoogland commented on code in PR #7279:
URL: https://github.com/apache/cloudstack/pull/7279#discussion_r1115348702
##########
engine/schema/src/main/java/com/cloud/upgrade/GuestOsMapper.java:
##########
@@ -102,8 +102,16 @@ private boolean addGuestOs(long categoryId, String
displayName) {
guestOS = guestOSDao.persist(guestOS);
return (guestOS != null);
}
+ public void addGuestOsHypervisorMapping(GuestOSHypervisorMapping mapping,
long category, String displayName) {
+ long guestOsId = getGuestOsId(category, displayName);
+ if (guestOsId == 0) {
+ LOG.warn(String.format("no guest os found for category %d and name
%s, skipping mapping it to %s/%s", guestOsId, displayName,
mapping.getHypervisorType(), mapping.getHypervisorVersion()));
Review Comment:
```suggestion
LOG.error(String.format("no guest os found for category %d and
name %s, skipping mapping it to %s/%s", guestOsId, displayName,
mapping.getHypervisorType(), mapping.getHypervisorVersion()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
