nvazquez opened a new pull request, #7287:
URL: https://github.com/apache/cloudstack/pull/7287

   ### Description
   
   This PR fixes the console access for Vmware 6.7 which offers SecurityType = 
1 (None) - Reference: 
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#721none
   
   The CPVM access uses the RFB protocol 3.8 since #7015 (previously it used 
version 3.3). From the link above:
   ````
   Version 3.8 onwards
   The protocol continues with the SecurityResult message.
   Version 3.3 and 3.7
   The protocol passes to the initialisation phase ([Initialisation 
Messages](https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#initialisation-messages)).
   ````
   
   This PR fixes the behavior of the security type None, continuing with the 
SecurityResult message instead of the Initialisation Phase as it was on version 
3.3
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [x] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [x] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Vmware 6.7 environment
   Access any VM console before the fix -> Observe that the console is visible 
for less than a second, then an error is thrown
   After the fix -> Console access works fine
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to