weizhouapache commented on issue #7341:
URL: https://github.com/apache/cloudstack/issues/7341#issuecomment-1471579066

   I had a quick check, the new setting should be propogated to all agents.
   
   
https://github.com/apache/cloudstack/blob/main/server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java#L209-L227
   ```
       @Override
       public void propagateMSListToAgents() {
           LOG.debug("Propagating management server list update to agents");
           final String lbAlgorithm = getLBAlgorithmName();
           final Map<Long, List<Long>> dcOrderedHostsMap = new HashMap<>();
           for (final Host host : getAllAgentBasedHosts()) {
               final Long dcId = host.getDataCenterId();
               if (!dcOrderedHostsMap.containsKey(dcId)) {
                   dcOrderedHostsMap.put(dcId, getOrderedHostIdList(dcId));
               }
               final List<String> msList = 
getManagementServerList(host.getId(), host.getDataCenterId(), 
dcOrderedHostsMap.get(dcId));
               final Long lbCheckInterval = 
getLBPreferredHostCheckInterval(host.getClusterId());
               final SetupMSListCommand cmd = new SetupMSListCommand(msList, 
lbAlgorithm, lbCheckInterval);
               final Answer answer = agentManager.easySend(host.getId(), cmd);
               if (answer == null || !answer.getResult()) {
                   LOG.warn(String.format("Failed to setup management servers 
list to the agent of %s", host));
               }
           }
       }
   ```
   
   
   it looks like there is a bug somewhere.
   
   
   
   
   > @weizhouapache
   > 
   > The configuration parameter for "host" is dynamic , so there is no 
management service restart is required.
   > 
   > We have to restart the agent "cloudstack-agent " only after making the 
changes in the files
   > 
   > cat /etc/cloudstack/agent/agent.properties cat 
/usr/local/cloud/systemvm/conf/agent.properties
   > 
   > ```
   > MariaDB [cloud]> select * from configuration where name="host" \G;
   > *************************** 1. row ***************************
   >      category: Advanced
   >      instance: DEFAULT
   >     component: ApiServiceConfiguration
   >          name: host
   >         value: 10.0.32.222,10.0.33.251
   >   description: The ip address of management server. This can also accept 
comma separated addresses.
   > default_value: localhost
   >       updated: 2023-03-13 10:35:51
   >         scope: Global
   >    is_dynamic: 1
   >      group_id: 6
   >   subgroup_id: 26
   >        parent: NULL
   >  display_text: Host
   >          kind: CSV
   >       options: NULL
   > ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to