weizhouapache commented on code in PR #7355:
URL: https://github.com/apache/cloudstack/pull/7355#discussion_r1144365188


##########
client/src/main/java/org/apache/cloudstack/ServerDaemon.java:
##########
@@ -241,6 +242,14 @@ private void createHttpsConnector(final HttpConfiguration 
httpConfig) {
             sslConnector.setPort(httpsPort);
             sslConnector.setHost(bindInterface);
             server.addConnector(sslConnector);
+
+            // add scanner to auto-reload certs
+            try {
+                KeyStoreScanner scanner = new 
KeyStoreScanner(sslContextFactory);
+                server.addBean(scanner);
+            } catch (Throwable ex) {

Review Comment:
   sonarcloud suggests
   ```
   Catch Exception instead of Throwable.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to