DaanHoogland commented on code in PR #7289:
URL: https://github.com/apache/cloudstack/pull/7289#discussion_r1151573719
##########
test/integration/smoke/test_vm_schedule.py:
##########
@@ -175,78 +172,6 @@ def test_02_list_vm_schedules(self):
self.assertEqual(response[0].action,
"start",
- "check the action of vm schedule is start!"
- )
- return
-
- @attr(tags=["advanced", "advancedns", "smoke", "simulator"],
required_hardware="true")
- def test_03_update_vm_schedule(self):
- """Test to update VM schedules
- """
-
- cmd = updateVMSchedule.updateVMScheduleCmd()
- cmd.virtualmachineid = self.virtual_machine.id
- cmd.description = "update description of vm"
- cmd.tag = "bye"
- cmd.intervaltype = "DAILY"
- cmd.schedule = "45"
-
- response = self.apiclient.updateVMSchedule(cmd)
-
- self.assertEqual(
- response.schedule,
- "45",
- "Check the action of vm is start!"
- )
- return
-
- @attr(tags=["advanced", "advancedns", "smoke", "simulator"],
required_hardware="true")
- def test_04_enable_vm_schedule(self):
- """Test to enable VM schedules
- """
-
- cmd = enableVMSchedule.enableVMScheduleCmd()
- cmd.vmscheduleid = 91
-
- response = self.apiclient.enableVMSchedule(cmd)
-
- self.assertEqual(
- response.success,
- True,
- "VM schedule is not enabled "
- )
- return
-
- @attr(tags=["advanced", "advancedns", "smoke", "simulator"],
required_hardware="true")
- def test_05_disable_vm_schedule(self):
- """Test to disable VM schedules
- """
-
- cmd = disableVMSchedule.disableVMScheduleCmd()
- cmd.vmscheduleid = 91
-
- response = self.apiclient.disableVMSchedule(cmd)
-
- self.assertEqual(
- response.success,
- True,
- "VM schedule is not disabled"
- )
- return
-
- @attr(tags=["advanced", "advancedns", "smoke", "simulator"],
required_hardware="true")
- def test_06_delete_vm_schedule(self):
- """Test to delete VM schedules
- """
-
- cmd = deleteVMSchedule.deleteVMScheduleCmd()
- cmd.vmscheduleid = 91
-
- response = self.apiclient.deleteVMSchedule(cmd)
-
- self.assertEqual(
- response.success,
- True,
- "VM schedule is not removed "
+ "check the response action of vm schedule is start!"
Review Comment:
your comment here is "minor change ..." but you remove 4 test cases. Is that
on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
