[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7373: Allow admin/user to filter by state for Pods, Clusters and Hosts

[via GitHub]

shwstppr commented on code in PR #7373:
URL: https://github.com/apache/cloudstack/pull/7373#discussion_r1155737313


##########
ui/src/config/section/infra/hosts.js:
##########
@@ -24,6 +24,10 @@ export default {
   icon: 'desktop-outlined',
   permission: ['listHostsMetrics'],
   resourceType: 'Host',
+  filters: () => {
+    const filters = ['enabled', 'disabled']

Review Comment:
   @rohityadavcloud cc @kishankavala I guess this PR adds filter for host 
`resourcestate` which can only be,
   ```
   Creating,
   Enabled,
   Disabled,
   ErrorInPrepareForMaintenance,
   PrepareForMaintenance,
   ErrorInMaintenance,
   Maintenance,
   Error,
   Degraded
   ```
   
   Not sure if we have filtering for host state as well which can be host 
`status` as well which can be,
   
   ```
   Creating
   Connecting
   Up
   Down
   Disconnected
   Alert
   Removed
   Error
   Rebalancing
   Unknown
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org