harikrishna-patnala commented on code in PR #7381:
URL: https://github.com/apache/cloudstack/pull/7381#discussion_r1159373021


##########
engine/schema/src/main/java/com/cloud/upgrade/dao/DatabaseAccessObject.java:
##########
@@ -26,6 +26,17 @@ public class DatabaseAccessObject {
 
     private static Logger s_logger = 
Logger.getLogger(DatabaseAccessObject.class);
 
+    public void addForeignKey(Connection conn, String tableName, String 
tableColumn, String foreignTableName, String foreignColumnName) {
+        String addForeignKeyStmt = String.format("CALL 
`cloud`.`IDEMPOTENT_ADD_FOREIGN_KEY`('%s', '%s', '%s', '%s')", tableName, 
tableColumn, foreignTableName, foreignColumnName);

Review Comment:
   So you are saying we should not use the procedure in future also (I suppose 
you are saying to avoid errors with multiple mysql versions) ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to