DaanHoogland commented on code in PR #7274:
URL: https://github.com/apache/cloudstack/pull/7274#discussion_r1168898368
##########
.github/workflows/ci.yml:
##########
@@ -186,7 +186,8 @@ jobs:
component/test_vpc_offerings
component/test_vpc_routers
component/test_vpn_users",
- "component/test_vpc_network_lbrules" ]
+ "component/test_vpc_network_lbrules",
+ "component/test_router_resources"]
Review Comment:
this means it gets its own run(ner), which might not be the most economic
way to do it.
##########
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java:
##########
@@ -270,7 +281,7 @@ public void incrementResourceCount(long accountId,
ResourceType type, Long... de
return;
}
- long numToIncrement = (delta.length == 0) ? 1 : delta[0].longValue();
+ long numToIncrement = (delta.length == 0) ? 1 : delta[0];
Review Comment:
`null`s may be passed as `Long`s. Not sure if this is better than calling
`longValue()` on a null. I think more check is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
