JoaoJandre commented on code in PR #7445:
URL: https://github.com/apache/cloudstack/pull/7445#discussion_r1172570781


##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java:
##########
@@ -79,16 +79,46 @@ public class HttpUploadServerHandler extends 
SimpleChannelInboundHandler<HttpObj
 
     private boolean requestProcessed = false;
 
-    private static final String HEADER_SIGNATURE = "x-signature";
-
-    private static final String HEADER_METADATA = "x-metadata";
+    enum UploadHeader {
+        SIGNATURE("signature"),
+        METADATA("metadata"),

Review Comment:
   ```suggestion
           METADATA("x-metadata"),
   ```



##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java:
##########
@@ -79,16 +79,46 @@ public class HttpUploadServerHandler extends 
SimpleChannelInboundHandler<HttpObj
 
     private boolean requestProcessed = false;
 
-    private static final String HEADER_SIGNATURE = "x-signature";
-
-    private static final String HEADER_METADATA = "x-metadata";
+    enum UploadHeader {
+        SIGNATURE("signature"),

Review Comment:
   ```suggestion
           SIGNATURE("x-signature"),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to