shwstppr commented on PR #7421:
URL: https://github.com/apache/cloudstack/pull/7421#issuecomment-1543472359

   @rohityadavcloud Sorry didn't get you completely.
   This PR or a change in the event description won't create an issue but if we 
refactor the event type to VM.DEPLOY as you said in your last comment I feel 
there could be an issue with usage processing as usage_event stores the type of 
the event,
   ```
   MariaDB [cloud_usage]> select * from usage_event WHERE type='VM.CREATE';
   
+----+-----------+------------+---------------------+---------+-------------+-----------------------------+-------------+-------------+------+---------------+-----------+--------------+
   | id | type      | account_id | created             | zone_id | resource_id 
| resource_name               | offering_id | template_id | size | 
resource_type | processed | virtual_size |
   
+----+-----------+------------+---------------------+---------+-------------+-----------------------------+-------------+-------------+------+---------------+-----------+--------------+
   |  6 | VM.CREATE |          2 | 2023-05-10 12:24:53 |       1 |           4 
| test-control-188059f1a44    |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 10 | VM.CREATE |          2 | 2023-05-10 12:25:19 |       1 |           5 
| test-node-188059f80a5       |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 26 | VM.CREATE |          2 | 2023-05-10 13:02:41 |       1 |           6 
| test-control-18805c0e74b    |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 30 | VM.CREATE |          2 | 2023-05-10 13:04:38 |       1 |           7 
| test-node-18805c3790b       |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 44 | VM.CREATE |          2 | 2023-05-10 13:09:59 |       1 |           8 
| ftret-control-18805c86337   |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 48 | VM.CREATE |          2 | 2023-05-10 13:10:19 |       1 |           9 
| ftret-node-18805c8b35e      |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 65 | VM.CREATE |          2 | 2023-05-10 13:35:39 |       1 |          10 
| vdsgfds-control-18805dfe3ba |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   | 69 | VM.CREATE |          2 | 2023-05-10 13:36:17 |       1 |          11 
| vdsgfds-node-18805e079db    |          13 |           8 | NULL | VMware       
 |         1 |         NULL |
   
+----+-----------+------------+---------------------+---------+-------------+-----------------------------+-------------+-------------+------+---------------+-----------+--------------+
   8 rows in set (0.00 sec)
   ```
   Also, the same event type would be published on the event bus


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to