DaanHoogland commented on code in PR #7588:
URL: https://github.com/apache/cloudstack/pull/7588#discussion_r1221310703
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -2510,6 +2508,12 @@ public Boolean doInTransaction(final TransactionStatus
status) {
for (final VlanVO vlan : vlans) {
_vlanDao.remove(vlan.getId());
}
+ // we should actually
+// VmwareDatacenterZoneMapVO vmwareZoneMapping =
_vmwareDatacenterZoneMapDao.findByZoneId(zoneId)
+// if (vmwareZoneMapping != null) {
+//
_vmwareDatacenterZoneMapDao.removeByZoneId(vmwareZoneMapping.getId());
+// }
+ // but we don't know about vmware/plugin/hypervisors at this
point
Review Comment:
guess not, just informative
```suggestion
// we should actually find the mapping and remove if it
exists
// but we don't know about vmware/plugin/hypervisors at this
point
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
