weizhouapache commented on PR #7570:
URL: https://github.com/apache/cloudstack/pull/7570#issuecomment-1584150938

   looks good.
   
   checked two rocky8 environment
   
   - without this PR
   
   ```
   mysql> select * from host_details where name not in ('username','password');
   
+----+---------+----------------------------------------------------+---------------------------+
   | id | host_id | name                                               | value  
                   |
   
+----+---------+----------------------------------------------------+---------------------------+
   |  1 |       1 | Host.OS.Kernel.Version                             | 
6.3.6-1.el8.elrepo.x86_64 |
   |  2 |       1 | com.cloud.network.Networks.RouterPrivateIpStrategy | 
HostLocal                 |
   |  3 |       1 | Host.OS.Version                                    | 8.4    
                   |
   |  4 |       1 | host.volume.encryption                             | true   
                   |
   |  5 |       1 | secured                                            | true   
                   |
   |  6 |       1 | Host.OS                                            | Rocky  
                   |
   | 15 |       2 | Host.OS.Kernel.Version                             | 
6.3.6-1.el8.elrepo.x86_64 |
   | 16 |       2 | com.cloud.network.Networks.RouterPrivateIpStrategy | 
HostLocal                 |
   | 17 |       2 | Host.OS.Version                                    | 8.4    
                   |
   | 18 |       2 | host.volume.encryption                             | true   
                   |
   | 19 |       2 | secured                                            | true   
                   |
   | 20 |       2 | Host.OS                                            | Rocky  
                   |
   ```
   
   - with this PR
   
    ```
   mysql> select * from host_details where name not in ('username','password');
   
+----+---------+----------------------------------------------------+---------------------------+
   | id | host_id | name                                               | value  
                   |
   
+----+---------+----------------------------------------------------+---------------------------+
   |  1 |       1 | Host.OS.Kernel.Version                             | 
6.3.6-1.el8.elrepo.x86_64 |
   |  2 |       1 | com.cloud.network.Networks.RouterPrivateIpStrategy | 
HostLocal                 |
   |  3 |       1 | Host.OS.Version                                    | 8.4    
                   |
   |  4 |       1 | host.volume.encryption                             | true   
                   |
   |  5 |       1 | secured                                            | true   
                   |
   |  6 |       1 | Host.OS                                            | Rocky 
Linux               |
   | 15 |       2 | Host.OS.Kernel.Version                             | 
6.3.6-1.el8.elrepo.x86_64 |
   | 16 |       2 | com.cloud.network.Networks.RouterPrivateIpStrategy | 
HostLocal                 |
   | 17 |       2 | Host.OS.Version                                    | 8.4    
                   |
   | 18 |       2 | host.volume.encryption                             | true   
                   |
   | 19 |       2 | secured                                            | true   
                   |
   | 20 |       2 | Host.OS                                            | Rocky 
Linux               |
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to