DaanHoogland commented on code in PR #7580:
URL: https://github.com/apache/cloudstack/pull/7580#discussion_r1241957358
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/VifDriverBase.java:
##########
@@ -44,15 +44,15 @@ public void configure(Map<String, Object> params) throws
ConfigurationException
_pifs = (Map<String, String>)params.get("libvirt.host.pifs");
}
- protected String getControllCidr(String defaultValue, Map<String, Object>
params) {
- String controllCidr =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.CONTROLL_CIDR);
- if (StringUtils.isBlank(controllCidr)) {
- controllCidr = (String) params.get("control.cidr");
+ protected String getControlCidr(String defaultValue, Map<String, Object>
params) {
+ String controlCidr =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.CONTROL_CIDR);
+ if (StringUtils.isBlank(controlCidr)) {
+ controlCidr = (String) params.get("control.cidr");
}
- if (StringUtils.isBlank(controllCidr)) {
- controllCidr = defaultValue;
+ if (StringUtils.isBlank(controlCidr)) {
+ controlCidr = defaultValue;
Review Comment:
You may want to only define this for a small number (a pod or one of the
zones) (??)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
