harikrishna-patnala commented on code in PR #7689:
URL: https://github.com/apache/cloudstack/pull/7689#discussion_r1251076435
##########
plugins/storage/volume/scaleio/src/main/java/org/apache/cloudstack/storage/datastore/provider/ScaleIOHostListener.java:
##########
@@ -171,11 +171,7 @@ private ModifyStoragePoolAnswer
sendModifyStoragePoolCommand(ModifyStoragePoolCo
@Override
public boolean hostDisconnected(long hostId, long poolId) {
- StoragePoolHostVO storagePoolHost =
_storagePoolHostDao.findByPoolHost(poolId, hostId);
- if (storagePoolHost != null) {
- _storagePoolHostDao.deleteStoragePoolHostDetails(hostId, poolId);
- }
-
Review Comment:
I think race condition happening in multiple management server setup. Yes
all entries are getting deleting when host is removed, so upon adding it again
new entries will be made. Even if SDC ID is changed which is unlikely event,
even then it will be updated during host connect. @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
