DaanHoogland commented on code in PR #7545:
URL: https://github.com/apache/cloudstack/pull/7545#discussion_r1259738380
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java:
##########
@@ -55,7 +55,7 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
private String displayText;
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING,
description = "the availability of network offering."
- + " Default value is Required for Guest Virtual network offering;
Optional for Guest Direct network offering")
+ + " Default value is Required for Guest Virtual network offering;
Optional for Guest Direct network offering; Only one network offering can have
the value Required ")
Review Comment:
```suggestion
+ " The default value is Required for Guest Virtual network
offering, Optional for Guest Direct network offering. Only one network offering
can have the value Required ")
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -73,7 +73,8 @@ public class CreateNetworkOfferingCmd extends BaseCmd {
@Parameter(name = ApiConstants.SPECIFY_VLAN, type = CommandType.BOOLEAN,
description = "true if network offering supports vlans")
private Boolean specifyVlan;
- @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING,
description = "the availability of network offering. Default value is Optional")
+ @Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING,
description = "the availability of network offering. Default value is Optional"
+ + " Other value is Required, which will make it as the default network
offering for new networks ")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.AVAILABILITY, type = CommandType.STRING,
description = "the availability of network offering. The default value is
Optional. "
+ " Another value is Required, which will make it as the default network
offering for new networks ")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
