weizhouapache commented on code in PR #7799:
URL: https://github.com/apache/cloudstack/pull/7799#discussion_r1291022095
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2798,16 +2798,24 @@ public GuestOS addGuestOs(final AddGuestOsCmd cmd) {
guestOsVo.setIsUserDefined(true);
final GuestOS guestOsPersisted = _guestOSDao.persist(guestOsVo);
- if (cmd.getDetails() != null && !cmd.getDetails().isEmpty()) {
- Map<String, String> detailsMap = cmd.getDetails();
- for (Object key : detailsMap.keySet()) {
- _guestOsDetailsDao.addDetail(guestOsPersisted.getId(),
(String)key, detailsMap.get(key), false);
- }
- }
+ Map<String, String> details = cmd.getDetails();
+ Boolean forDisplay = cmd.getForDisplay();
Review Comment:
if we use a detail for display/not-display, it will bring more work on
- update guest os between display/not-display
- list guest OSes by display or not-display
if we add a column in upgrade sql or in java, will there be exception during
upgrade ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
