DaanHoogland commented on code in PR #7853:
URL: https://github.com/apache/cloudstack/pull/7853#discussion_r1294253886
##########
plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java:
##########
@@ -107,6 +107,10 @@ public boolean checkAccess(User user, String commandName)
throws PermissionDenie
@Override
public boolean checkAccess(Account account, String commandName) {
+ if (isEnabled()) {
+ return true;
+ }
Review Comment:
yes @hsato03 I think you are right. I consider it a bug that the
StaticRoleBasedAPIAccessChecker.isEnabled() would return true if it is disabled
(but the dynamic one is enabled). Maybe this is a discussion out of scope for
your change. As said, "if this prevents the escalation talked about (it is)
fine"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
