weizhouapache commented on code in PR #7082:
URL: https://github.com/apache/cloudstack/pull/7082#discussion_r1295765587
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java:
##########
@@ -16,28 +16,30 @@
// under the License.
package org.apache.cloudstack.api.command.user.offering;
+import org.apache.cloudstack.api.BaseCmd;
Review Comment:
`BaseCmd` is not required
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -3105,9 +3109,10 @@ private Pair<List<ServiceOfferingJoinVO>, Integer>
searchForServiceOfferingsInte
Integer cpuSpeed = cmd.getCpuSpeed();
Boolean encryptRoot = cmd.getEncryptRoot();
+ caller = _accountMgr.finalizeOwner(caller, accountName, domainId,
projectId);
Review Comment:
should this be `owner` ?
`caller` should be a final variable which cannot be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
