DaanHoogland commented on code in PR #7848:
URL: https://github.com/apache/cloudstack/pull/7848#discussion_r1296764843
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1215,7 +1215,7 @@ public TemplateInfo prepareIso(long isoId, long dcId,
Long hostId, Long poolId)
tmplt = _tmplFactory.getReadyBypassedTemplateOnPrimaryStore(isoId,
poolId, hostId);
bypassed = true;
} else {
- tmplt = _tmplFactory.getTemplate(isoId, DataStoreRole.Image, dcId);
+ tmplt = _tmplFactory.getReadyTemplateOnImageStore(isoId, dcId);
Review Comment:
looking at the implementations both calls are functionaly similar and should
be unified. `getReadyTemplateOnImageStore` has `DataStoreRole.Image`
hard-coded, while `getTemplate` gets it as a parameter. I am not sure if this
will help anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
