DaanHoogland commented on code in PR #7880:
URL: https://github.com/apache/cloudstack/pull/7880#discussion_r1301258017
##########
test/integration/component/test_update_vm.py:
##########
@@ -152,6 +142,111 @@ def test_update_vm_name(self):
self.assertEqual(vmnew.displayname, vmnewstarted.displayname,
msg="display name changed on start, displayname is %s" %
vmnewstarted.displayname)
+ @attr(tags=['advanced', 'simulator', 'basic', 'sg', 'details'],
required_hardware="false")
+ def test_update_vm_details_admin(self):
+ """Test Update VirtualMachine Details
+
+ # Set up a VM
+ # Set up hidden detail in DB for VM
+
+ # Validate the following:
+ # 1. Can add two details (detail1, detail2)
+ # 2. Can fetch new details on VM
+ # 3. Can delete detail1
+ # 4. Hidden detail not removed
+ # 6. The detail2 remains
+ # 7. Ensure cleanup parameter doesn't remove hidden details
+ """
+ hidden_detail_name = "configDriveLocation"
+ detail1 = "detail1"
+ detail2 = "detail2"
+
+ # set up a VM
+ self.virtual_machine = VirtualMachine.create(
+ self.apiclient,
+ self.testdata["virtual_machine"],
+ accountid=self.account.name,
+ zoneid=self.zone.id,
+ domainid=self.account.domainid,
+ serviceofferingid=self.service_offering.id,
+ templateid=self.template.id
+ )
Review Comment:
this one somehow got lost:
```suggestion
self.virtual_machine = VirtualMachine.create(
self.apiclient,
self.testdata["virtual_machine"],
accountid=self.account.name,
zoneid=self.zone.id,
domainid=self.account.domainid,
serviceofferingid=self.service_offering.id,
templateid=self.template.id
)
self.cleanup.append(self.virtual_machine)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
