DaanHoogland commented on code in PR #7909:
URL: https://github.com/apache/cloudstack/pull/7909#discussion_r1305368689
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -496,9 +496,8 @@ public boolean configure(String name, Map<String, Object>
params) {
AssignIpAddressSearch.and("dc",
AssignIpAddressSearch.entity().getDataCenterId(), Op.EQ);
AssignIpAddressSearch.and("allocated",
AssignIpAddressSearch.entity().getAllocatedTime(), Op.NULL);
AssignIpAddressSearch.and("vlanId",
AssignIpAddressSearch.entity().getVlanId(), Op.IN);
- if (SystemVmPublicIpReservationModeStrictness.value()) {
- AssignIpAddressSearch.and("forSystemVms",
AssignIpAddressSearch.entity().isForSystemVms(), Op.EQ);
- }
+ AssignIpAddressSearch.and("forSystemVms",
AssignIpAddressSearch.entity().isForSystemVms(), Op.EQ);
Review Comment:
so now, whether the setting is true or false, we allow testing for it in the
query!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
