[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7878: Publish event for VM.STOP when out of band stop is detected

[via GitHub]

DaanHoogland commented on code in PR #7878:
URL: https://github.com/apache/cloudstack/pull/7878#discussion_r1305402521


##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java:
##########
@@ -162,6 +177,8 @@ private void processReport(long hostId, Map<Long, 
VirtualMachine.PowerState> tra
                         }
 
                         _messageBus.publish(null, 
VirtualMachineManager.Topics.VM_POWER_STATE, PublishScope.GLOBAL, 
instance.getId());
+                        ActionEventUtils.onActionEvent(User.UID_SYSTEM, 
Account.ACCOUNT_ID_SYSTEM,instance.getDomainId(),
+                                EventTypes.EVENT_VM_STOP, "Out of band VM 
power off", instance.getId(), ApiCommandResourceType.VirtualMachine.toString());

Review Comment:
   @mlsorensen , this is very hard to reproduce as it depends on the order of 
power sync reports coming in from hosts. I'll give this a swing after 4.18.1, 
and think about simulating race conditions. code looks good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org